Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix: add useDane config option #94270

Merged
merged 1 commit into from Aug 13, 2020
Merged

postfix: add useDane config option #94270

merged 1 commit into from Aug 13, 2020

Conversation

jerith666
Copy link
Contributor

Motivation for this change

After #90115, my postfix configuration began failing to evaluate because I had smtp_tls_security_level = "dane". This restores my ability to enable DANE.

cc @asbachb @peti @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jerith666 jerith666 requested a review from peti as a code owner July 31, 2020 00:44
Mic92
Mic92 reviewed Jul 31, 2020
View reviewed changes
nixos/modules/services/mail/postfix.nix
@@ -508,6 +510,14 @@ in
'';
};

useDane = mkOption {
Copy link
Member

@Mic92 Mic92 Jul 31, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this not be smtp_tls_security_level exposed directly? Then it would allow full control over the value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked like the intent of #90115 was to derive smtp_tls_security_level from the value of tlsTrustedAuthorities and/or sslCert, so I stuck with that.

Though I did just notice that since I developed this, #94270 has landed, which also alters the value of smtp_tls_security_level under different conditions ... so, cc @typetetris @petabyteboy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value could be computed based on tlsTrustedAuthorities and sslCert.

@Mic92
Copy link
Member

Mic92 commented Jul 31, 2020

Apart from that is dane something we want to consider as a default? cc @asbachb

@asbachb
Copy link
Contributor

asbachb commented Aug 1, 2020 •
edited

Apart from that is dane something we want to consider as a default? cc @asbachb

I personally won't enable it by default until the verification fails by default.

@Mic92 Mic92 merged commit 0f2ee10 into NixOS:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@asbachb asbachb asbachb left review comments

@peti peti Awaiting requested review from peti peti is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerith666 @Mic92 @asbachb