Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython: 0.29.19 -> 0.29.21 #94245

Merged
merged 1 commit into from Jul 30, 2020
Merged

Cython: 0.29.19 -> 0.29.21 #94245

merged 1 commit into from Jul 30, 2020

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jul 30, 2020

Motivation for this change

Required for latest Numpy to build, among other things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@K900
Cython 0.29.19 -> 0.29.21
2dfe9f4 
Required for latest Numpy to build, among other things.
@FRidh
Copy link
Member

FRidh commented Jul 30, 2020

@GrahamcOfBorg build python3.pkgs.cython

@FRidh FRidh changed the base branch from master to staging July 30, 2020 16:38
@FRidh FRidh merged commit 1c82cf4 into NixOS:staging Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K900 @FRidh @Janik-Haag