Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrum-ltc: fix #94238 #94244

Merged
merged 1 commit into from Aug 21, 2020
Merged

electrum-ltc: fix #94238 #94244

merged 1 commit into from Aug 21, 2020

Conversation

bbjubjub2494
Copy link
Member

Motivation for this change

#94238

Things done

Apply wrapQtApp and check GUI functionality.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (No diff detected, stopping review...)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494
Copy link
Member Author

Long term it would make more sense to refactor both versions of electrum together since they are very similar.

@veprbl veprbl linked an issue Jul 30, 2020 that may be closed by this pull request
@Lassulus Lassulus merged commit 5fd9f0a into NixOS:master Aug 21, 2020
@bbjubjub2494 bbjubjub2494 deleted the electrum-ltc branch December 31, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electrum-ltc: GUI cannot start under GNOME
2 participants