Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.qds_sdk: 1.12.0 -> 1.15.2 #94263

Closed
wants to merge 1 commit into from
Closed

pythonPackages.qds_sdk: 1.12.0 -> 1.15.2 #94263

wants to merge 1 commit into from

Conversation

tinahbu
Copy link
Contributor

@tinahbu tinahbu commented Jul 30, 2020

Motivation for this change

Add version 1.15.2 of qds_sdk to Nix OSS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from shahrukh330 July 30, 2020 22:32
kalbasit
kalbasit requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one. The commit title should be:

pythonPackages.qds_sdk: 1.12.0 -> 1.15.2

The same thing applies to the title of your pull request.

👉 https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

pkgs/development/python-modules/qds_sdk/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for adhering to CONTRIBUTING, please use the following commit msg:

python3Packages.qds_sdk: 1.12.0 -> 1.15.2

@tinahbu tinahbu changed the title updated qds_sdk version to 1.15.2 pythonPackages.qds_sdk: 1.12.0 -> 1.15.2 Jul 31, 2020
@tinahbu tinahbu closed this Jul 31, 2020
@tinahbu
Copy link
Contributor Author

tinahbu commented Jul 31, 2020

will create a new PR with the correct commit message

@kalbasit
Copy link
Member

@tinahbu no need to create a new PR, you can just force push to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@kalbasit kalbasit kalbasit requested changes

@FRidh FRidh Awaiting requested review from FRidh

@shahrukh330 shahrukh330 Awaiting requested review from shahrukh330

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tinahbu @kalbasit @jonringer @Janik-Haag