Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several (neo-)vim plugins and update #94262

Merged
merged 6 commits into from Jul 31, 2020

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Several useful plugins and plugin updates.
I've been quite lazy with adding a PR for these, so I've been testing most of these locally every day for quite a while.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/94262
1 package failed to build:
vimPlugins.YouCompleteMe

80 packages built:
vimPlugins.agda-vim vimPlugins.ale vimPlugins.awesome-vim-colorschemes vimPlugins.calendar-vim vimPlugins.coc-fzf vimPlugins.coc-nvim vimPlugins.colorizer vimPlugins.completion-nvim vimPlugins.conjure vimPlugins.defx-git vimPlugins.defx-icons vimPlugins.defx-nvim vimPlugins.delimitMate vimPlugins.denite-git vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-khard vimPlugins.deoplete-nvim vimPlugins.diagnostic-nvim vimPlugins.far-vim vimPlugins.fzf-vim vimPlugins.git-messenger-vim vimPlugins.i3config-vim vimPlugins.iceberg-vim vimPlugins.julia-vim vimPlugins.lexima-vim vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.ncm2-neoinclude vimPlugins.ncm2-syntax vimPlugins.ncm2-vim vimPlugins.neoformat vimPlugins.neosnippet-snippets vimPlugins.neoterm vimPlugins.neovim-fuzzy vimPlugins.neoyank-vim vimPlugins.nerdtree vimPlugins.neuron-vim vimPlugins.nvim-treesitter vimPlugins.splitjoin-vim vimPlugins.syntastic vimPlugins.tagbar vimPlugins.vim vimPlugins.vim-airline vimPlugins.vim-autoformat vimPlugins.vim-bazel vimPlugins.vim-codefmt vimPlugins.vim-cue vimPlugins.vim-devicons vimPlugins.vim-dirvish-git vimPlugins.vim-floaterm vimPlugins.vim-fugitive vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-javacomplete2 vimPlugins.vim-jsdoc vimPlugins.vim-maktaba vimPlugins.vim-move vimPlugins.vim-multiple-cursors vimPlugins.vim-mundo vimPlugins.vim-pandoc vimPlugins.vim-pandoc-syntax vimPlugins.vim-pencil vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-quickrun vimPlugins.vim-rooter vimPlugins.vim-ruby vimPlugins.vim-sandwich vimPlugins.vim-snippets vimPlugins.vim-table-mode vimPlugins.vim-test vimPlugins.vim-themis vimPlugins.vim-tmux vimPlugins.vim-visual-multi vimPlugins.vim-vsnip vimPlugins.vim-vsnip-integ vimPlugins.vimtex vimPlugins.yats-vim vimPlugins.zig-vim

@jonringer jonringer merged commit b0b724f into NixOS:master Jul 31, 2020
@rvolosatovs rvolosatovs deleted the feature/vim-plugins branch June 14, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants