New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdhomerun-config-gui: init at 20200521 #94254
Conversation
dd8e4bd
to
85c1569
Compare
The build will fail because I have some patching to do. From the Arch user repo:
I know it needs the library libhdhomerun and that its filename is libhdhomerun.so. I just don't know what path to put in the file src/Makefile.am (line 2 above). |
Try --- a/pkgs/applications/video/hdhomerun_config_gui/default.nix
+++ b/pkgs/applications/video/hdhomerun_config_gui/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchurl, libhdhomerun, pkg-config, gnumake, gtk2 }:
+{ stdenv, fetchurl, libhdhomerun, pkg-config, gtk2 }:
stdenv.mkDerivation rec {
pname = "hdhomerun_config_gui";
@@ -9,18 +9,14 @@ stdenv.mkDerivation rec {
sha256 = "1r1rwfgi714nwblyg8nqjzkpm4n2lg7kqqqas47hvbn5waimz1ja";
};
- buildInputs = [
- pkg-config gnumake gtk2
- ];
+ nativeBuildInputs = [ pkg-config ];
+ buildInputs = [ gtk2 libhdhomerun ];
- buildPhase = ''
- ./configure
- make
- '';
+ configureFlags = [ "CPPFLAGS=-I${libhdhomerun}/include/hdhomerun" ];
+ makeFlags = [ "SUBDIRS=src" ];
installPhase = ''
- mkdir -p $out/usr/bin/
- install -Dm 755 hdhomerun_config_gui $out/usr/bin/hdhomerun_config_gui
+ install -vDm755 src/hdhomerun_config_gui $out/usr/bin/hdhomerun_config_gui
'';
meta = with stdenv.lib; { |
af62fa4
to
5fca00e
Compare
@rycee When having "libhdhomerun" installed on Arch and running "hdhomerun_config discover" whereas with NixOS nothing happens. |
@LouisDK1 Sorry, I can't help with that. In general packages should be able to access the network without you having to do anything special. I suspect you will have to try to use strace and/or wireshark to figure out what's going on. |
5fca00e
to
4c51b2d
Compare
Turns out it has a firewall related issue. I have suggested adding a comment in another pull req for libhdhomerun. I've made some changes. "vlc" has to be installed for the application to playback streams hence added. |
Nice, rebased to master in 2204f74 🙂 |
Package does not build yet. I'll need to patch it to link to libhdhomerun.so from the libhdhomerun package and make sure it won't conflict.
Motivation for this change
hdhomerun_config_gui is currently not present in nixpkgs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)