Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcHEAD: 8.11.20200505 -> 8.11.20200731 #94321

Merged
merged 1 commit into from Aug 7, 2020
Merged

ghcHEAD: 8.11.20200505 -> 8.11.20200731 #94321

merged 1 commit into from Aug 7, 2020

Conversation

utdemir
Copy link
Member

@utdemir utdemir commented Jul 31, 2020

Motivation for this change

This PR updates ghcHEAD to the latest revision as of today (2020-07-31).

There is one major change, now instead of integer-simple and integer-gmp, we have a ghc-bignum package with different backends. So I added a new compiler set like haskell.packages.native-bignum.ghcHEAD.

Also, the next version will be called GHC 9.0, so instead of calling this 8.11 we might call it something like 9.0-dev.

Let me know what you think.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@utdemir Could you rebase this on the haskell-updates branch?

Also, after rebasing, could you try to get ofborg to build some of these packages for you? I'd like to see that it actually is building successfully.

Oh, and it looks like the grahamcofborg-eval check is failing. It appears to be related to this PR?

@utdemir utdemir changed the base branch from master to haskell-updates July 31, 2020 21:10
@ofborg ofborg bot requested review from peti and kosmikus July 31, 2020 21:20
@utdemir
Copy link
Member Author

utdemir commented Jul 31, 2020 •
edited

@utdemir Could you rebase this on the haskell-updates branch?

Oh, and it looks like the grahamcofborg-eval check is failing. It appears to be related to this PR?

Done, and yes, it was related to this PR, I just fixed it; thanks!

Also, after rebasing, could you try to get ofborg to build some of these packages for you? I'd like to see that it actually is building successfully.

I do not think ofborg trusts me enough to do that, and even if it did I do not know if we should make it compile two GHC's, might be a bit heavy. If that is fine, someone with enough permissions can run:

@GrahamcOfBorg build haskell.compiler.ghcHEAD haskell.compiler.native-bignum.ghcHEAD

@utdemir
Copy link
Member Author

utdemir commented Jul 31, 2020

It looks like ofborgs aarch64-linux build has failed x86_64-linux build has timed out. Even though I built both on my NixOS x86_64 system. I do not have an ARM system, so if anyone else can debug it, here's the error:

rts/Libdw.c:363:6: error: #error "Please implement set_initial_registers() for your arch"
  363 | #    error "Please implement set_initial_registers() for your arch"
      |      ^~~~~
rts/ghc.mk:585: rts/dist/build/.depend-v-p-dyn-l-debug-thr-thr_debug-thr_l-thr_p-debug_dyn-thr_dyn-thr_debug_dyn-l_dyn-thr_l_dyn-thr_debug_p-debug_p.c_asm: No such file or directory

cdepillabout
cdepillabout approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for fixing this up @utdemir.

It would be great if @ggreif could do a quick review of this, since he is often responsible for updating these GHC derivations here in nixpkgs.

If he signs off on this, I'm happy to merge it in.

@utdemir If he doesn't respond in a few days, feel free to ping me and I will merge it in anyway.

As for the arm build, it is unfortunate they don't "just work", but without an arm machine it is hard to debug it. I don't think too many people actually use this ghcHEAD package set, so I'm fine with just going ahead and merging this in.

@ggreif
Copy link
Contributor

ggreif commented Aug 1, 2020

Just for comparison

@GrahamcOfBorg build haskell.compiler.integer-simple.ghc884 haskell.compiler.integer-simple.ghc8101

@ggreif
Copy link
Contributor

ggreif commented Aug 1, 2020 •
edited

@utdemir Thanks for doing this, it will be simpler to follow up on GHC 9.0 after this patch!

@cdepillabout this looks totally reasonable to me.

It appears that the non-gmp builds are wonky on aarch64 too:

configuring
/nix/store/iccnwksp0hfffsv3x7qcf73f043b4znq-stdenv-linux/setup: line 106: GhcLibWays: command not found
error: --- Error --- nix-daemon

Maybe @domenkozar can comment.

@domenkozar
Copy link
Member

@ggreif assuming you tried 8.8.4 or 8.10.1 I've just pushed a fix 1353355

Thanks for the report!

@peti peti merged this pull request into NixOS:haskell-updates Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@peti peti Awaiting requested review from peti

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@utdemir @cdepillabout @ggreif @domenkozar @peti