Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matplotlib: 3.2.1 -> 3.3.0 #94248

Closed
wants to merge 1 commit into from
Closed

matplotlib: 3.2.1 -> 3.3.0 #94248

wants to merge 1 commit into from

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jul 30, 2020

Motivation for this change

New upstream version.

Things done

Updated version, added new setup.cfg setting to build with system Freetype instead of trying to download and vendor it at build time (what even).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 30, 2020

@GrahamcOfBorg build python3.pkgs.matplotlib

@FRidh FRidh changed the base branch from master to staging July 30, 2020 16:38
@ofborg ofborg bot requested review from lovek323 and veprbl July 30, 2020 16:45
@veprbl
Copy link
Member

veprbl commented Jul 31, 2020

@GrahamcOfBorg build python2.pkgs.matplotlib

@FRidh
Copy link
Member

FRidh commented Jul 31, 2020

Python 2 uses a different expression.

@veprbl
Copy link
Member

veprbl commented Jul 31, 2020

And the same setup.cfg

@K900 K900 changed the base branch from staging to master August 4, 2020 09:17
@K900
Copy link
Contributor Author

K900 commented Aug 4, 2020

Rebased on top of latest master, added the missing Pillow dependency as well. Seems like one of the checks got stuck from the previous run, so I didn't get a notification :(

@K900
Copy link
Contributor Author

K900 commented Aug 4, 2020

I'm not too sure what happened here with the labels and the CI failures. Can someone please help troubleshoot?

@K900 K900 requested a review from jonringer August 5, 2020 08:02
@alyssais alyssais removed their request for review August 11, 2020 16:17
@veprbl
Copy link
Member

veprbl commented Aug 26, 2020

This has landed as 8e5e7e2

@veprbl veprbl closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@lovek323 lovek323 Awaiting requested review from lovek323

@veprbl veprbl Awaiting requested review from veprbl

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@infinisil infinisil Awaiting requested review from infinisil

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@tfc tfc Awaiting requested review from tfc

@ttuegel ttuegel Awaiting requested review from ttuegel

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@K900 @FRidh @veprbl @jonringer @alyssais