[COOP] ReportingObserver [1/M] Add WPT tests. #24823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 31, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2332257
branch
from
af6f37e
to
a93cb42
Compare
When an access is made in between two windows that would be put in different browsing context group if COOP was enforced, we should dispatch events to the ReportingObserver(s) and display error messages. This patch adds the first two basic WPT tests. A few more are also coming in follow-ups, in particular when the access is made from an iframe. Branch: [1/M] This patch. Bug: 1111691 Change-Id: I38d7092c9edb664b9f2936c7a86f2c488fafde9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332257 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794105}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2332257
branch
from
a93cb42
to
5ff3f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an access is made in between two windows that would be put in
different browsing context group if COOP was enforced, we should
dispatch events to the ReportingObserver(s) and display error messages.
This patch adds the first two basic WPT tests. A few more are also
coming in follow-ups, in particular when the access is made from an
iframe.
Branch:
[1/M] This patch.
Bug: 1111691
Change-Id: I38d7092c9edb664b9f2936c7a86f2c488fafde9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332257
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794105}