Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #94296

Merged
merged 88 commits into from Aug 4, 2020
Merged

Staging next #94296

merged 88 commits into from Aug 4, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jul 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Calvin-L and others added 30 commits March 18, 2020 21:15
MacOS 10.15 now includes "aligned_alloc".  Disagreement between the
headers and the binaries about whether aligned_alloc exists leads to
a compilation failure (see #73319 and the detailed comment in this
commit).
This fixes problems with missing symbols when using clang as library and
is most likely a result of llvm being build with RTTI enabled.
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
Updated for compatibility with perl 5.32
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
Added Pod::Parser as a dependency, since perl 5.32 no longer includes
this module in core.
This upgrades dbus-python to the 1.2.16 release. Reason for this version
upgrade is a the failing hamster application (see. programs.hamster).
With a 1.2.12 dbus-python version hamster can not start and fails with:

    Traceback (most recent call last):
      File "/nix/store/5ax21lyiprc9v5l3pl7dbfr2hqbrh970-hamster-3.0.2/bin/.hamster-wrapped", line 41, in <module>
        from hamster import client, reports
      File "/nix/store/5ax21lyiprc9v5l3pl7dbfr2hqbrh970-hamster-3.0.2/lib/python3.8/site-packages/hamster/client.py", line 46, in <module>
        assert not (
    AssertionError: python3.8 changed str(<dbus integers>).
       That broke hamster (projecthamster/hamster#477).
       Please upgrade to dbus-python >= 1.2.14.
Backwards incompatible changes:
- Removed support for passing an Extension instance to
  from_issuer_subject_key_identifier(), as per our deprecation policy.
- Support for LibreSSL 2.7.x, 2.8.x, and 2.9.0 has been removed (2.9.1+
  is still supported).
- Dropped support for macOS 10.9, macOS users must upgrade to 10.10 or
  newer.
- RSA generate_private_key() no longer accepts public_exponent values
  except 65537 and 3 (the latter for legacy purposes).
- X.509 certificate parsing now enforces that the version field contains
  a valid value, rather than deferring this check until version is
  accessed.

Deprecations:
- Deprecated support for Python 2. At the time there is no time table
  for actually dropping support, however we strongly encourage all users
  to upgrade their Python, as Python 2 no longer receives support from
  the Python core team.
Right now we add glibc to search path also -nostdinc was provided,
which breaks projects providing their own gcc.
@FRidh
Copy link
Member Author

FRidh commented Jul 31, 2020

systemd fails to build cc @flokli https://hydra.nixos.org/build/124583734

@flokli
Copy link
Contributor

flokli commented Jul 31, 2020

@FRidh looking at the hydra log, this seems to be some incompatibility with libmicrohttpd:

../src/journal-remote/journal-remote-main.c: In function ‘setup_microhttpd_server’:
../src/journal-remote/journal-remote-main.c:431:38: error: passing argument 5 of ‘MHD_start_daemon’ from incompatible pointer type [-Werror=incompatible-pointer-types]

We can probably just disable that whole feature for now - we don't install the unit files anyways.

This disabled systemd-journal-upload and systemd-journal-remote.

We didn't install the unit files anyways, so this was probably not used
at all, and currently fails to build due to libmicrohttpd and systemd
code being incompatible:

```
../src/journal-remote/journal-remote-main.c: In function ‘setup_microhttpd_server’:
../src/journal-remote/journal-remote-main.c:431:38: error: passing argument 5 of ‘MHD_start_daemon’ from incompatible pointer type [-Werror=incompatible-pointer-types]
```
@flokli flokli mentioned this pull request Jul 31, 2020
10 tasks
@flokli
Copy link
Contributor

flokli commented Jul 31, 2020

@FRidh I opened a PR, directed towards staging-next at #94356 which fixes the build for me.

@FRidh
Copy link
Member Author

FRidh commented Aug 1, 2020

libreoffice fails to build https://hydra.nixos.org/build/124674530

@kristoff3r
Copy link
Contributor

libreoffice fails to build https://hydra.nixos.org/build/124674530

I spent a couple of minutes debugging this, and it looks like the breakage comes from the icu default being upgraded. Apparently they changed their macros to require semi-colons after them, and at least one is present in the pinned libreoffice version. I guess libreoffice needs to still get icu64 or be upgraded.

@FRidh
Copy link
Member Author

FRidh commented Aug 4, 2020

qtwebkit fails https://hydra.nixos.org/build/124672735
I thought that was deprecated and that applications such as kmail would not depend on it any longer. It seems it's used via messagelib, which I think not necessarily needs qtwebkit.

It is deprecated and an optional requirement.
@FRidh FRidh requested a review from ttuegel as a code owner August 4, 2020 10:47
@gebner
Copy link
Member

gebner commented Aug 4, 2020

@FRidh qtwebkit is not deprecated, it's just community maintained now.

@FRidh
Copy link
Member Author

FRidh commented Aug 4, 2020

I should have referred to #53079

@FRidh FRidh merged commit 8a78890 into master Aug 4, 2020
@orivej orivej mentioned this pull request Aug 8, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet