Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk-layer-shell: 0.1.0 -> 0.2.0 #94272

Merged
merged 2 commits into from Aug 30, 2020

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/wmww/gtk-layer-shell/releases.

meta.description for gtk-layer-shell is: "A library to create panels and other desktop components for Wayland using the Layer Shell protocol"

meta.homepage for gtk-layer-shell is: ""

meta.changelog for gtk-layer-shell is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
gtk-layer-shell
waybar
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/yj5nqyfvvc765jv4r7rqq8xc5yjbz190-gtk-layer-shell-0.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gtk-layer-shell https://github.com/r-ryantm/nixpkgs/archive/2d84afa72d1e4b64601a9a9db246a4004b09ab53.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/yj5nqyfvvc765jv4r7rqq8xc5yjbz190-gtk-layer-shell-0.2.0
ls -la /nix/store/yj5nqyfvvc765jv4r7rqq8xc5yjbz190-gtk-layer-shell-0.2.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages built:
  • gtk-layer-shell
  • waybar

Maintainer pings

cc @eonpatapon for testing.

Copy link
Member

@tadeokondrak tadeokondrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license is now LGPLv3 (from MIT). https://github.com/wmww/gtk-layer-shell/releases

Copy link
Contributor

@eonpatapon eonpatapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waybar works fine

@jtojnar
Copy link
Contributor

jtojnar commented Aug 9, 2020

Asked about the relicensing in wmww/gtk-layer-shell#40 (comment)

@wmww
Copy link

wmww commented Aug 10, 2020

I don't know if meta.changelog needs to be something more specific, but I noticed it's empty and I do now have a changelog here: https://github.com/wmww/gtk-layer-shell/blob/master/CHANGELOG.md

@jtojnar
Copy link
Contributor

jtojnar commented Aug 10, 2020

For projects that are on GitHub and include the changes in GitHub releases there is no need to set meta.changelog, we already link to the release. Though the changelog files are still useful.

I opened an issue against our updater: nix-community/nixpkgs-update#230

* Use `pkg-config` instead of the alias.
* `gobject-introspection` is used during build for GIR generation, move it to `nativeBuildInputs`.
* Remove unused `out` meson flag.
* Enable docs.
* Split to multiple outputs.
@jtojnar jtojnar force-pushed the auto-update/gtk-layer-shell branch from 2d84afa to 6164ca0 Compare August 10, 2020 14:54
@jtojnar
Copy link
Contributor

jtojnar commented Aug 10, 2020

Updated the license field and also cleaned up the package a bit and enabled docs.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Aug 30, 2020
@jtojnar jtojnar merged commit e487caa into NixOS:master Aug 30, 2020
@r-ryantm r-ryantm deleted the auto-update/gtk-layer-shell branch August 31, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants