Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why3: 1.2.1 -> 1.3.1 #94258

Merged
merged 1 commit into from Jul 30, 2020
Merged

why3: 1.2.1 -> 1.3.1 #94258

merged 1 commit into from Jul 30, 2020

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jul 30, 2020 •
edited

Important: keeping why3 at 1.2.1 precludes framac 21.+ from having WP
plugin enabled, which is arguably a very important plugin.

Motivation for this change

Frama-C 21.+ requires why 1.3.1 for WP plugin to be enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yrashk
why3: 1.2.1 -> 1.3.1
f740f11 
Important: keeping why3 at 1.2.1 precludes framac 21.+ from having WP
plugin enabled, which is arguably a very important plugin.
@yrashk yrashk mentioned this pull request Jul 30, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from thoughtpolice and vbgl July 30, 2020 20:32
@bjornfor bjornfor merged commit cc8369c into NixOS:master Jul 30, 2020
@bobismijnnaam bobismijnnaam mentioned this pull request Jul 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yrashk @bjornfor