Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blackmagic: unstable-2020-02-20 -> unstable-2020-08-05 #94994

Merged
merged 1 commit into from Aug 10, 2020
Merged

blackmagic: unstable-2020-02-20 -> unstable-2020-08-05 #94994

merged 1 commit into from Aug 10, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 9, 2020

Motivation for this change

Noticed that the build fails.

  • Fixes build.
  • libftdi, pc-hosted, and pc-stlinkv2 platforms are replaced by
    hosted.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
blackmagic: unstable-2020-02-20 -> unstable-2020-08-05
c8b3a0a 
- Fixes build.
- `libftdi`, `pc-hosted`, and `pc-stlinkv2` platforms are replaced by
  `hosted`.
@ofborg ofborg bot requested review from emilazy, pjones and sorki August 9, 2020 08:57
emilazy
emilazy approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@danieldk danieldk merged commit 0a53fcc into NixOS:master Aug 10, 2020
@danieldk danieldk deleted the blackmagic-unstable-2020-08-05 branch August 17, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@pjones pjones Awaiting requested review from pjones

@sorki sorki Awaiting requested review from sorki

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @emilazy