networking: Set networking.search to [domain] by default #94986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is impossible to set `networking.search` to an empty list: in this case the option will not appear in the config at all, which is semantically different from having `search` with an empty list in resolv.conf. There is a workaround – set `networking.search = ["."]`, but it is not very obvious. Change the logic of resolv.conf generation to always include the `search` option and instead default it to `networking.domain` in the NixOS module. * For people who had `networking.search` unset, this will set it to the list consisting of their domain, which will result in `search <networking.domain>` being added to their `resolv.conf`, which is equivalent to having `search` option, i.e. the behaviour will not change. * For people who set `networking.search` to a non-empty list exactly the same resolv.conf as before will be generated. * For people who set `networking.search = []` previously this would have no effect, now it will actually result in the empty search list in their resolv.conf, which is, arguably, what they expect.
|
cc @wkennington as the author and @7c6f434c as the merger of #2380. |
|
I think empty |
|
Yes, I mean, explicitly putting an empty |
|
Apparently, |
|
@kirelagin please resolve the merge conflict. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The net effect of this PR is that it allows setting
networking.search = []. Please, see the commit message for details.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)