Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix grep in setupHook #94943

Merged
merged 1 commit into from Aug 8, 2020
Merged

cmake: fix grep in setupHook #94943

merged 1 commit into from Aug 8, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 8, 2020 •
edited

Motivation for this change

This produced a warning:

grep: Invalid range end

In a [], - has to come last.

Fixes #93166.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
cmake: fix grep in setupHook
cec26d6 
This produced a warning:

> grep: Invalid range end

In a [], - has to come last.

Reported-by: Daniël de Kok <me@danieldk.eu>
Fixes: 75fdc1c
@vcunat vcunat merged commit cec26d6 into NixOS:staging Aug 8, 2020
@alyssais alyssais deleted the cmake branch April 9, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@jtojnar jtojnar jtojnar approved these changes

@vcunat vcunat vcunat approved these changes

@acowley acowley Awaiting requested review from acowley

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @danieldk @jtojnar @vcunat