Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules-closure: don't ignore all deps if the first is builtin #95008

Closed
wants to merge 1 commit into from
Closed

modules-closure: don't ignore all deps if the first is builtin #95008

wants to merge 1 commit into from

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Aug 9, 2020 •
edited

Motivation for this change

The previous version resulted in modules being omitted entirely
because the first dependency listed for them by modprobe was
built-in. Now, only the actual built-in modules will be ignored when
building the closure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TODO: test if this fixes the issue for me in practice it does!

@ofborg test boot

@lheckemann
modules-closure: don't ignore all deps if the first is builtin
5dba8f2 
The previous version resulted in modules being omitted entirely
because the first dependency listed for them by modprobe was
built-in. Now, only the actual built-in modules will be ignored when
building the closure.
@xaverdh
Copy link
Contributor

xaverdh commented Aug 9, 2020

#92081 for prior art

@lheckemann
Copy link
Member Author

That's much better!

@lheckemann lheckemann closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lheckemann @xaverdh