Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shattered-pixel-dungeon: 0.8.1a -> 0.8.2, add test #95007

Merged
merged 2 commits into from Aug 9, 2020
Merged

shattered-pixel-dungeon: 0.8.1a -> 0.8.2, add test #95007

merged 2 commits into from Aug 9, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Aug 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz fgaz force-pushed the shattered-pixel-dungeon/0.8.2 branch from 87cbf8c to c5dea26 Compare August 9, 2020 13:27
@fgaz fgaz changed the title shattered-pixel-dungeon: 0.8.1 -> 0.8.2, add test shattered-pixel-dungeon: 0.8.1a -> 0.8.2, add test Aug 9, 2020
@ofborg ofborg bot added the 6.topic: nixos label Aug 9, 2020
@fgaz fgaz force-pushed the shattered-pixel-dungeon/0.8.2 branch from c5dea26 to 8a8714d Compare August 9, 2020 13:52
@fgaz
Copy link
Member Author

fgaz commented Aug 9, 2020

Well, I now know that, while it does build, the game does not run on aarch64.

@fgaz fgaz force-pushed the shattered-pixel-dungeon/0.8.2 branch from 8a8714d to 82963ef Compare August 9, 2020 22:08
jonringer
jonringer approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95007 1

1 package built:
- shattered-pixel-dungeon

@jonringer jonringer merged commit 6cfda0e into NixOS:master Aug 9, 2020
@fgaz fgaz deleted the shattered-pixel-dungeon/0.8.2 branch August 10, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @jonringer