tdrop: 2018-11-13 -> 2020-05-14 #94985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
danieldk
suggested changes
Aug 10, 2020
|
Thank you for your first contribution! I have added some initial suggested changes. |
wedens
force-pushed
the
tdrop-version-bump
branch
from
583c3c9
to
fedff54
Compare
|
It's not the first one, but thanks for the review :) I've applied your suggestions. |
For some reason GitHub says first-time contributor ;). |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)The simplest way to to test that it works is to run
tdrop -a auto_hide && <command> && tdrop -a auto_show, where<command>is some GUI app. It'll hide a terminal window, open a GUI app and when you close the app, it'll show the same terminal window.