zfs-prune-snapshots: init at 1.1.0 #94955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 9, 2020
maintainers/maintainer-list.nix
Outdated
| @@ -9243,7 +9243,7 @@ | |||
| }; | |||
| ymarkus = { | |||
| name = "Yannick Markus"; | |||
| email = "nixpkgs@ymarkus.dev"; | |||
There was a problem hiding this comment.
this should be a separate commit:
maintainers: update ymarkus email
| stdenv.mkDerivation rec { | ||
| version = "1.1.0"; | ||
| pname = "zfs-prune-snapshots"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
unneeded
Suggested change
| name = "${pname}-${version}"; |
Comment on lines
17
to
19
| buildPhase = '' | ||
| make man | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| buildPhase = '' | |
| make man | |
| ''; | |
| makeTargets = [ "man" ]; |
ymarkus
force-pushed
the
zfs-prune-snapshots
branch
from
cc4161d
to
ac103f8
Compare
|
Thanks, @jonringer. I've changed the lines you marked in the review and tested it. Please re-review! |
jonringer
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed ymarkus' email
Motivation for this change
Add zfs-prune-snapshots tool
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)