Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidequest: 0.10.2 -> 0.10.11 #94946

Merged
merged 1 commit into from Aug 22, 2020
Merged

sidequest: 0.10.2 -> 0.10.11 #94946

merged 1 commit into from Aug 22, 2020

Conversation

afreakk
Copy link
Contributor

@afreakk afreakk commented Aug 8, 2020 •
edited

Motivation for this change

Some games (like contractors) requires newest version of sidequest to install.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@afreakk
Copy link
Contributor Author

afreakk commented Aug 10, 2020

Btw sidequest changed license to non-free, one of these versions
Not sure what to do about that.

@alyssais
Copy link
Member

Btw sidequest changed license to non-free, one of these versions
Not sure what to do about that.

Well, definitely update the license meta. You might also want to consider keeping the last free version around, and only using the non-free one for things that absolutely need it.

@infinisil
Copy link
Member

Here is the info on it becoming unfree: https://github.com/the-expanse/SideQuest/commit/f355a9e718694ea489376476f616588b1c36ba0d#commitcomment-41523044

However this doesn't apply to the current state of the repo, so this PR here is fine to merge in its current state.

The next update to sidequest will probably have to be done with the new repo at https://github.com/SideQuestVR/SideQuest once that's official.

@infinisil infinisil merged commit 34e4b4f into NixOS:master Aug 22, 2020
@leo60228 leo60228 mentioned this pull request Aug 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afreakk @alyssais @infinisil