Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.ijavascript: init at 5.2.0 #94945

Closed
wants to merge 1 commit into from
Closed

nodePackages.ijavascript: init at 5.2.0 #94945

wants to merge 1 commit into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 8, 2020

Motivation for this change

Adding jupyter kernels in this case ijavascript kernel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc mentioned this pull request Aug 8, 2020
Closed
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2020

Result of nixpkgs-review pr 94945 1

1 package failed to build:
- joplin
11 packages built:
- lumo
- mastodon-bot
- postcss-cli
- redoc-cli
- vimPlugins.coc-git
- vimPlugins.coc-java
- vimPlugins.coc-prettier
- vimPlugins.coc-stylelint
- vimPlugins.coc-tsserver
- vimPlugins.coc-vetur
- wasm-text-gen

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 28, 2020 •
edited

@costrouc Can you please separate the init and the regenerate command and fix the merge conflict?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 2, 2021 •
edited

PR got combined with a few other node updates. Closing so that the update goes trough smoothly.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @SuperSandro2000 @ryantm