Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitsi: fix desktop category; patch #94941

Merged
merged 1 commit into from Aug 8, 2020
Merged

jitsi: fix desktop category; patch #94941

merged 1 commit into from Aug 8, 2020

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Aug 8, 2020

The patch was trying to add LD_LIBRARY_PATH to the beginning of the
wrapper, but it was failing to do that.

There are still background errors when starting the binary.

Motivation for this change

fix warnings about desktop category being invalid

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The patch was trying to add LD_LIBRARY_PATH to the beginning of the
wrapper, but it was failing to do that.

There are still background errors when starting the binary.
@ryantm ryantm merged commit 37fd49b into NixOS:master Aug 8, 2020
@ryantm ryantm deleted the fix-jitsi branch August 8, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants