Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iruby: init at 0.3.0 #94947

Merged
merged 1 commit into from Aug 9, 2020
Merged

iruby: init at 0.3.0 #94947

merged 1 commit into from Aug 9, 2020

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 8, 2020

Motivation for this change

iruby kernel for jupyter

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc mentioned this pull request Aug 8, 2020
Closed
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2020

Result of nixpkgs-review pr 94947 1

1 package built:
- iruby

@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2020

@GrahamcOfBorg build iruby

jonringer
jonringer approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94947 1

1 package built: - iruby

@jonringer jonringer merged commit 0772bb3 into NixOS:master Aug 9, 2020
@jonringer
Copy link
Contributor

I'm not a big fan of large deps.nix, but not familiar with a better way

@costrouc
Copy link
Member Author

costrouc commented Aug 9, 2020

Yeah neither am I. It would be nice if it worked the same way that R and python packages do. But I'm guessing that that is only necessary as the number of packages in the language increases.

@jonringer
Copy link
Contributor

I'm not familiar with R, but python packages usually need some "elbow" grease for them to work as a semi-coherent package set.

However, it does enable python packages to not need mutually exclusive deps trees to work.

@costrouc costrouc deleted the ruby-iruby-init branch August 9, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@costrouc @jonringer