Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtcreator: 4.11.0 -> 4.12.4 #95002

Closed
wants to merge 1 commit into from
Closed

qtcreator: 4.11.0 -> 4.12.4 #95002

wants to merge 1 commit into from

Conversation

glaebhoerl
Copy link
Contributor

Motivation for this change

QtCreator 4.11 had a bug that rendered it unusable for me and the internet said 4.12 would work better. It was true.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • only qtcreator itself
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

glaebhoerl
glaebhoerl commented Aug 9, 2020
View reviewed changes
pkgs/development/tools/qtcreator/default.nix Outdated
preConfigure = ''
preConfigure = ''
substituteInPlace src/libs/libs.pro \
--replace '$$[QT_INSTALL_QML]/QtQuick/Controls' '${qtquickcontrols}/${qtbase.qtQmlPrefix}/QtQuick/Controls'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a use of $$[QT_INSTALL_QML] (which doesn't exist in that form) was added to libs.pro, the fix is the same as for plugins.pro on the lines below

@ofborg ofborg bot requested a review from akaWolf August 9, 2020 12:15
@jonringer
Copy link
Contributor

not related to our pr, but I'm unable to build this due to clang failing to build:

builder for '/nix/store/mbgyhgjzwkmmcp8aia4ikdpc5skvjcrc-clang-10.0.1.drv' failed with exit code 1; last 10 log lines:

  CMake Error at /nix/store/szq3jbixhpclajqmhkn8bnm6ni23096j-llvm-10.0.1/lib/cmake/llvm/AddLLVM.cmake:447 (add_library):
    No SOURCES given to target: obj.clangCodeGen
  Call Stack (most recent call first):
    cmake/modules/AddClang.cmake:100 (llvm_add_library)
    lib/CodeGen/CMakeLists.txt:41 (add_clang_library)


  CMake Generate step failed.  Build files cannot be regenerated correctly.
  builder for '/nix/store/mbgyhgjzwkmmcp8aia4ikdpc5skvjcrc-clang-10.0.1.drv' failed with exit code 1

SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/development/tools/qtcreator/default.nix
Comment on lines +33 to +35
optionals withClangPlugins [ llvmPackages_10.libclang
clang_qt_vendor
llvmPackages_10.llvm ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
optionals withClangPlugins [ llvmPackages_10.libclang
clang_qt_vendor
llvmPackages_10.llvm ];
optionals withClangPlugins [ llvmPackages_10.libclang clang_qt_vendor llvmPackages_10.llvm ];

@sikmir
Copy link
Member

sikmir commented Jan 19, 2021

@glaebhoerl meanwhile 4.14.0 is available. please update.

@glaebhoerl
Copy link
Contributor Author

alas I don't have time to spend on this, if anyone else does, feel free to reopen (or make a new one or whatever)

@glaebhoerl glaebhoerl closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@akaWolf akaWolf Awaiting requested review from akaWolf

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glaebhoerl @jonringer @sikmir @SuperSandro2000