nixos/redmine: patch mercurial integration #94999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
requested changes
Aug 9, 2020
| @@ -21,6 +21,8 @@ in | |||
|
|
|||
| buildInputs = [ rubyEnv rubyEnv.wrappedRuby rubyEnv.bundler ]; | |||
|
|
|||
| patches = [ ./0001-python3.patch ]; | |||
There was a problem hiding this comment.
let's add this comment here:
# taken from https://www.redmine.org/issues/33784
# can be dropped when the upstream bug is closed and the fix is present in the upstream release
prusnak
approved these changes
Aug 9, 2020
|
@GrahamcOfBorg test redmine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mercurial integration in redmine does not work in NixOS due to incompatibilities between python versions as used in redmine and mercurial. This is described in issue #94949.
Things done
This fixes #94949 by incorporating a patch posted on the redmine issue tracker: https://www.redmine.org/issues/33784 which ports the redmine python2 script to python3
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)