Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cherrypy: 18.3.0 -> 18.6.0 #94981

Merged
merged 1 commit into from Aug 9, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 9, 2020

Motivation for this change

trying to fix

cc @costrouc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member

costrouc commented Aug 9, 2020

Result of nixpkgs-review pr 94981 1

1 package failed to build:
- bareos
15 packages built:
- ceph (ceph-dev)
- ceph-client
- flexget
- libceph
- mnemosyne
- python37Packages.cherrypy
- python37Packages.pyalgotrade
- python37Packages.ws4py
- python37Packages.zerobin
- python38Packages.cherrypy
- python38Packages.pyalgotrade
- python38Packages.ws4py
- python38Packages.zerobin
- sambaFull (samba4Full)
- tribler

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. bareos is failing due to other issues.

bareos logs

Compiling unix_fifo_device.c
if [ -d "unix_fifo_device.d" ]; then ../../../autoconf/mkinstalldirs config.d; /nix/store/cc64vcf0g3l5ck0c5pfwflcacb8x7i4d-coreutils-8.31/bin/cp -r unix_fifo_device.d/. config.d/.; fi
mkdir -p -- config.d
Making libbareossd-fifo.la ...
/build/bareos-17.2.7-src/libtool --silent --tag=CXX --mode=link /nix/store/qpr8zp6anrcd94cq6cgn3vv27nv54dyd-gcc-wrapper-9.3.0/bin/g++    -L../../lib -o libbareossd-fifo.la unix_fifo_device.lo -export-dynamic -rpath /nix/store/i168lwdbjcdy29x94gdv3f7ic20jnw7y-bareos-17.2.7/lib -release 17.2.7 \
                                                   -soname libbareossd-fifo-17.2.7.so -lbareos
libtool: ESC[31mwarningESC(BESC[m: ESC[1m'/nix/store/s0i7mmnzapfyr24fxlv1n59f3f0lnqbx-gcc-9.3.0-lib/lib/libstdc++.la' seems to be movedESC(BESC[m
Compiling generic_tape_device.c
if [ -d "generic_tape_device.d" ]; then ../../../autoconf/mkinstalldirs config.d; /nix/store/cc64vcf0g3l5ck0c5pfwflcacb8x7i4d-coreutils-8.31/bin/cp -r generic_tape_device.d/. config.d/.; fi
Making libbareossd-gentape.la ...
/build/bareos-17.2.7-src/libtool --silent --tag=CXX --mode=link /nix/store/qpr8zp6anrcd94cq6cgn3vv27nv54dyd-gcc-wrapper-9.3.0/bin/g++    -L../../lib -o libbareossd-gentape.la generic_tape_device.lo -export-dynamic -rpath /nix/store/i168lwdbjcdy29x94gdv3f7ic20jnw7y-bareos-17.2.7/lib -release 17.2.7 \
                                                   -soname libbareossd-gentape-17.2.7.so -lbareos
libtool: ESC[31mwarningESC(BESC[m: ESC[1m'/nix/store/s0i7mmnzapfyr24fxlv1n59f3f0lnqbx-gcc-9.3.0-lib/lib/libstdc++.la' seems to be movedESC(BESC[m
Compiling gfapi_device.c
ESC[01mESC[Kgfapi_device.c:ESC[mESC[K In member function 'ESC[01mESC[Kvirtual bool gfapi_device::d_truncate(DCR*)ESC[mESC[K':
ESC[01mESC[Kgfapi_device.c:550:34:ESC[mESC[K ESC[01;31mESC[Kerror: ESC[mESC[Ktoo few arguments to function 'ESC[01mESC[Kint glfs_ftruncate(glfs_fd_t*, off_t, glfs_stat*, glfs_stat*)ESC[m
ESC[K'
  550 |       if (glfs_ftruncate(m_gfd, 0ESC[01;31mESC[K)ESC[mESC[K != 0) {
      |                                  ESC[01;31mESC[K^ESC[mESC[K
In file included from ESC[01mESC[K../backends/gfapi_device.h:31ESC[mESC[K,
                 from ESC[01mESC[Kgfapi_device.c:34ESC[mESC[K:
ESC[01mESC[K/nix/store/cmpp5gyplv2c8shgqrjslj62193nd76z-glusterfs-7.6/include/glusterfs/api/glfs.h:768:1:ESC[mESC[K ESC[01;36mESC[Knote: ESC[mESC[Kdeclared here
  768 | ESC[01;36mESC[Kglfs_ftruncateESC[mESC[K(glfs_fd_t *fd, off_t length, struct glfs_stat *prestat,
      | ESC[01;36mESC[K^~~~~~~~~~~~~~ESC[mESC[K
make[1]: *** [Makefile:217: gfapi_device.lo] Error 1
make[1]: Leaving directory '/build/bareos-17.2.7-src/src/stored/backends'
make: *** [GNUmakefile:167: src/stored/backends] Error 2

@jonringer
Copy link
Contributor Author

bareos is failing on master

https://github.com/NixOS/nixpkgs/pull/94981
1 package failed to build:
bareos

15 packages built:
ceph ceph-client flexget libceph mnemosyne python37Packages.cherrypy python37Packages.pyalgotrade python37Packages.ws4py python37Packages.zerobin python38Packages.cherrypy python38Packages.pyalgotrade python38Packages.ws4py python38Packages.zerobin sambaFull tribler

@jonringer jonringer merged commit e413330 into NixOS:master Aug 9, 2020
@jonringer jonringer deleted the bump-cherrypy branch August 9, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants