python3.8-hdlparse: Init at 1.0.4 #94961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliott Villars <elliottvillars@gmail.com>
Signed-off-by: Elliott Villars <elliottvillars@gmail.com>
Signed-off-by: Elliott Villars <elliottvillars@gmail.com>
jonringer
reviewed
Aug 8, 2020
|
|
||
| buildPythonPackage rec { | ||
| pname = "hdlparse"; | ||
| version = "1.0.4"; |
There was a problem hiding this comment.
Suggested change
| version = "1.0.4"; | |
| version = "1.0.4"; | |
| {stdenv,buildPythonPackage, fetchPypi}: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "hdlparse"; |
There was a problem hiding this comment.
two spaces is standard indention
Suggested change
| pname = "hdlparse"; | |
| pname = "hdlparse"; |
| }; | ||
|
|
||
| #This module does not contain any tests. | ||
| doCheck = false; |
There was a problem hiding this comment.
Suggested change
| doCheck = false; | |
| doCheck = false; | |
| sha256 = "fb6230ed1e7a04a8f82f8d3fb59791d0751ae35e5b8e58dbbf2cbcf100d0d0f2"; | ||
| }; | ||
|
|
||
| #This module does not contain any tests. |
There was a problem hiding this comment.
Suggested change
| #This module does not contain any tests. | |
| # This module does not contain any tests. |
| @@ -0,0 +1,22 @@ | |||
| {stdenv,buildPythonPackage, fetchPypi}: | |||
There was a problem hiding this comment.
Suggested change
| {stdenv,buildPythonPackage, fetchPypi}: | |
| { stdenv, buildPythonPackage, fetchPypi}: |
| @@ -0,0 +1,22 @@ | |||
| {stdenv,buildPythonPackage, fetchPypi}: | |||
There was a problem hiding this comment.
stdenv isn't used
Suggested change
| {stdenv,buildPythonPackage, fetchPypi}: | |
| {lib,buildPythonPackage, fetchPypi}: |
|
|
||
| #This module does not contain any tests. | ||
| doCheck = false; | ||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| #This module does not contain any tests. | ||
| doCheck = false; | ||
| meta = with stdenv.lib; { | ||
| homepage = https://kevinpt.github.io/hdlparse/; |
There was a problem hiding this comment.
rfc 45
Suggested change
| homepage = https://kevinpt.github.io/hdlparse/; | |
| homepage = "https://kevinpt.github.io/hdlparse/"; |
| doCheck = false; | ||
| meta = with stdenv.lib; { | ||
| homepage = https://kevinpt.github.io/hdlparse/; | ||
| description = "Hdlparse is a simple package implementing a rudimentary parser for VHDL and Verilog."; |
There was a problem hiding this comment.
Already in context of the package, no period
Suggested change
| description = "Hdlparse is a simple package implementing a rudimentary parser for VHDL and Verilog."; | |
| description = "Rudimentary parser for VHDL and Verilog"; |
|
please squash all the commits, should be two: Please make this into a separate commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)