Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: relax cryptography dependency #94967

Merged
merged 2 commits into from Aug 8, 2020
Merged

home-assistant: relax cryptography dependency #94967

merged 2 commits into from Aug 8, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 8, 2020 •
edited

Motivation for this change

Both the home-assistant and python3Packages.hass-nabucasa package broke when cryptography was updated to 3.0 in 434a011.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • home-assistant
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt marked this pull request as draft August 8, 2020 21:43
@mweinelt
Copy link
Member Author

mweinelt commented Aug 8, 2020

ERROR: Could not find a version that satisfies the requirement cryptography==2.9.2 (from homeassistant==0.113.3) (from versions: none)

Yikes.

@mweinelt mweinelt changed the title python3Packages.hass-nabucasa: relax cryptography dependency home-assistant: relax cryptography dependency Aug 8, 2020
@mweinelt mweinelt marked this pull request as ready for review August 8, 2020 22:04
jonringer
jonringer approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94967 1

3 packages built: - home-assistant - python37Packages.hass-nabucasa - python38Packages.hass-nabucasa

@jonringer jonringer merged commit d6e21aa into NixOS:master Aug 8, 2020
@mweinelt mweinelt deleted the hass branch August 8, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@Scriptkiddi Scriptkiddi Awaiting requested review from Scriptkiddi

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @jonringer