Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] gitlab: 13.0.12 #94970

Merged
merged 6 commits into from Aug 12, 2020
Merged

[20.03] gitlab: 13.0.12 #94970

merged 6 commits into from Aug 12, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 8, 2020

Motivation for this change

Backport PR of #94968 (and all the previous bumps that were missing). There's no security fix for 12.10.x available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

globin and others added 6 commits August 8, 2020 23:39
@globin @flokli
gitlab: 12.10.8 -> 13.0.3
020666f 
https://about.gitlab.com/releases/2020/05/22/gitlab-13-0-released/
https://about.gitlab.com/releases/2020/05/27/security-release-13-0-1-released/
https://about.gitlab.com/releases/2020/05/29/gitlab-13-0-3-released/

The gitaly gitlab-shell config has moved into gitaly.toml. See
https://gitlab.com/gitlab-org/gitaly/-/issues/2182 for more info.

(cherry picked from commit 79454f1)
@talyz @flokli
gitlab: 13.0.3 -> 13.0.4
28a6694 
https://about.gitlab.com/releases/2020/06/03/critical-security-release-13-0-4-released/
(cherry picked from commit 0b5c534)
@flokli
gitlab: 13.0.4 -> 13.0.6
027cef0 
CI Token Access Control

An authorization issue discovered in the mirroring logic allowed read access to private repositories. This issue is now mitigated in the latest release and is waiting for a CVE ID to be assigned.

https://about.gitlab.com/releases/2020/06/10/critical-security-release-13-0-6-released/
(cherry picked from commit 38a4af7)
@flokli
gitlab: 13.0.6 -> 13.0.8 (NixOS#92060)
5829336 
(cherry picked from commit d986fcc)
@flokli
gitlab: 13.0.8 -> 13.0.9
347d3c4 
Security release: https://about.gitlab.com/releases/2020/07/06/critical-security-release-gitlab-13-1-3-released/

(cherry picked from commit f3a353f)
@flokli
gitlab: 13.0.9 -> 13.0.12
16ec57b 
(cherry picked from commit 30309e1)
@flokli flokli requested review from talyz, globin and a user August 8, 2020 21:51
@ofborg ofborg bot requested review from fpletz and ehmry August 8, 2020 22:41
@ghost
Copy link

ghost commented Aug 11, 2020

I have not tested a state migration from 12.x to 13.x but unless anyone else wants to test this more thoroughly I would approve even without extensive testing.

@flokli
Copy link
Contributor Author

flokli commented Aug 12, 2020

As these are just cherry-picks from master, which we already merged, and fix some security issues, I'm fine with merging it.

@flokli flokli merged commit 4e4906d into NixOS:release-20.03 Aug 12, 2020
@flokli flokli deleted the 20.03-gitlab-13.0.12 branch August 12, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @globin @talyz