Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libguestfs dependencies #94997

Closed
wants to merge 2 commits into from
Closed

Libguestfs dependencies #94997

wants to merge 2 commits into from

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Aug 9, 2020

Motivation for this change

Remove unused dependencies, add dependencies which can be useful (./configure script looks for them to enable additional functionalities and other distros already have them).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker August 9, 2020 10:54
@ajs124
Copy link
Member

ajs124 commented Sep 9, 2020

Needs a rebase.

@avnik
Copy link
Contributor Author

avnik commented Sep 10, 2020

Will rebase tomorrow (or more correct, replace commits with already rebased from my local-WIP branch)

@avnik
libguestfs: remove xen build dependency
ec0a9d8 
It not checked in configure scripts (no mentions in configure.ac nor
logs of `./configure` execution). Other distributives also not list it
as build dependency, so I feel it safe to be removed.
@avnik
libguestfs: add sleuthkit and yara dependencies
b6e7d67
@avnik
Copy link
Contributor Author

avnik commented Sep 20, 2020

@ajs124 rebase done

@euank
Copy link
Member

euank commented Jan 14, 2021

The 'xen' portion of this PR ended up happening in #108882, which means this needs a rebase again; hopefully this can get reviewed/merged after that

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avnik @ajs124 @euank @SuperSandro2000