Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.delta: 0.4.0 -> 0.4.1 #94971

Merged
merged 1 commit into from Aug 9, 2020
Merged

gitAndTools.delta: 0.4.0 -> 0.4.1 #94971

merged 1 commit into from Aug 9, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 8, 2020

https://github.com/dandavison/delta/releases/tag/0.4.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ma27 and marsam August 8, 2020 23:57
@ludovicc
Copy link

ludovicc commented Aug 9, 2020

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on Darwin
  • executables tested on Darwin
  • all depending packages build
Possible improvements
Comments

@marsam marsam merged commit 8b645da into NixOS:master Aug 9, 2020
@zowoq zowoq deleted the delta branch August 10, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @ludovicc @marsam