Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime-music: 0.11.0 -> 0.11.7 #93970

Merged
merged 1 commit into from Sep 10, 2020
Merged

sublime-music: 0.11.0 -> 0.11.7 #93970

merged 1 commit into from Sep 10, 2020

Conversation

albakham
Copy link
Member

@albakham albakham commented Jul 27, 2020 •
edited

Motivation for this change

Update to recent release 0.11.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@albakham albakham changed the title sublime-music: 0.11.0 -> 0.11.1 sublime-music: 0.11.0 -> 0.11.2 Aug 1, 2020
@albakham
Copy link
Member Author

albakham commented Aug 1, 2020

ping @jtojnar

@albakham albakham changed the title sublime-music: 0.11.0 -> 0.11.2 sublime-music: 0.11.0 -> 0.11.6 Aug 2, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 3, 2020 •
edited

Changes look okay though we might want to switch to 0.11.7, which has been released in the meanwhile. https://gitlab.com/sublime-music/sublime-music/-/issues/179 might be problematic.

@albakham albakham changed the title sublime-music: 0.11.0 -> 0.11.6 sublime-music: 0.11.0 -> 0.11.7 Aug 3, 2020
@albakham
Copy link
Member Author

albakham commented Aug 3, 2020

Changes look okay though we might want to switch to 0.11.7, which has been released in the meanwhile. https://gitlab.com/sublime-music/sublime-music/-/issues/179 might be problematic.

I don't think it's required to put the files in lib specifically in share since nixos doesn't work like that at the system level, so a patch may not be necessary?

Anyway, I updated to 0.11.7

@Lassulus Lassulus merged commit 065b4af into NixOS:master Sep 10, 2020
@sumnerevans
Copy link
Member

sumnerevans commented Sep 28, 2020 •
edited

@albakham thanks for maintaining this! You are correct that it is not required to put the files in /usr/share. No patch should be necessary since it will look in the directory of the root of the package first.

(Also, feel free to ping me on any questions you have with packaging Sublime Music.)

@albakham albakham deleted the pkg/sublime-music branch November 4, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@albakham @jtojnar @sumnerevans @Lassulus