Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: 1.28.3 -> 1.30.0 #94021

Closed
wants to merge 1 commit into from
Closed

golangci-lint: 1.28.3 -> 1.30.0 #94021

wants to merge 1 commit into from

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jul 27, 2020

Motivation for this change

Update golangci-lint to its latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, manveru and anpryl July 27, 2020 18:14
@oxzi oxzi changed the title golangci-lint: 1.28.3 -> 1.29.0 golangci-lint: 1.28.3 -> 1.30.0 Aug 4, 2020
@oxzi
Copy link
Member Author

oxzi commented Aug 4, 2020

I have updated the PR for the latest version, released in the meantime.

@oxzi
Copy link
Member Author

oxzi commented Aug 10, 2020

Updated the PR again to solve merge conflicts after cea7cd9. This also enables tests.

@oxzi
Copy link
Member Author

oxzi commented Aug 21, 2020

Closed because later PR #95614 was merged first.

@oxzi oxzi closed this Aug 21, 2020
@oxzi oxzi deleted the golangci-lint-v1.29.0 branch August 21, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@manveru manveru Awaiting requested review from manveru

@anpryl anpryl Awaiting requested review from anpryl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@oxzi