Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tor-browser: 9.5 -> 9.5.3 #94019

Merged
merged 2 commits into from Jul 31, 2020
Merged

Tor-browser: 9.5 -> 9.5.3 #94019

merged 2 commits into from Jul 31, 2020

Conversation

KarlJoad
Copy link
Contributor

@KarlJoad KarlJoad commented Jul 27, 2020 •
edited

Motivation for this change

https://blog.torproject.org/new-release-tor-browser-951

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KarlJoad KarlJoad marked this pull request as ready for review July 27, 2020 17:57
@KarlJoad KarlJoad changed the title Torbrowser9.5.1 update Tor-browser 9.5.1 update Jul 27, 2020
@TethysSvensson
Copy link
Contributor

TethysSvensson commented Jul 27, 2020 •
edited

I've tested this on my machine it works well enough to browse youtube with audio, at least when setting pulseaudioSupport = true.

Note that this fixes the current master, as version 9.5 has been yanked from their website.

@KarlJoad KarlJoad changed the title Tor-browser 9.5.1 update Tor-browser: 9.5 -> 9.5.1 Jul 27, 2020
@TethysSvensson
Copy link
Contributor

@KarlJoad Since 9.5.3 is already out, perhaps you could update the PR to use that instead?

@KarlJoad
Copy link
Contributor Author

9.5.3 came out just today. Will update the pull request soon.

@KarlJoad KarlJoad changed the title Tor-browser: 9.5 -> 9.5.1 Tor-browser: 9.5 -> 9.5.3 Jul 28, 2020
@TethysSvensson
Copy link
Contributor

I've just tested 9.5.3 as well. It seems to work too.

@colemickens colemickens mentioned this pull request Jul 30, 2020
Closed
jonringer
jonringer reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind squashing the the bump into the previous bump?

git rebase -i HEAD^
# switch lines if commits out of order
# change second commit from `pick` to `squash`
# save and exit

@KarlJoad
tor-browser-bundle-bin: 9.5 -> 9.5.3
b03d137 
Squashed commits:
1. tor-browser-bundle-bin: 9.5 -> 9.5.1
2. tor-browser-bundle-bin: 9.5.1 -> 9.5.3
@KarlJoad
Copy link
Contributor Author

do you mind squashing the the bump into the previous bump?

git rebase -i HEAD^
# switch lines if commits out of order
# change second commit from `pick` to `squash`
# save and exit

This should do the trick.

jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/94019
1 package built:
torbrowser

@jonringer
Copy link
Contributor

32bit version builds as well

@jonringer jonringer merged commit 1970c2d into NixOS:master Jul 31, 2020
@prusnak prusnak mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KarlJoad @TethysSvensson @jonringer @Janik-Haag