Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ihatemoney: fix CVE-2020-15120 #93939

Merged
merged 1 commit into from Jul 26, 2020
Merged

python3Packages.ihatemoney: fix CVE-2020-15120 #93939

merged 1 commit into from Jul 26, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change

fix CVE-2020-15120

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Maybe update to the new release instead.

https://github.com/spiral-project/ihatemoney/releases/tag/4.1.5

@symphorien
Copy link
Member Author

No we are already at 4.2 and it's not possible to downgrade (due to sqlite not being able to drop columns). The next release is 5.0 but is not ready yet.

@mweinelt mweinelt mentioned this pull request Jul 26, 2020
Merged
10 tasks
@mweinelt
Copy link
Member

@GrahamcOfBorg test ihatemoney

@mweinelt mweinelt merged commit e9e3d10 into NixOS:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @mweinelt