Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnupg22: fix reproducibility issue by applying a debian patch #93937

Closed
wants to merge 1 commit into from
Closed

gnupg22: fix reproducibility issue by applying a debian patch #93937

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 26, 2020 •
edited

Motivation for this change

Fix reproducibility issue https://r13y.com/diff/5ae313d84d3caae035453d7e836ff94edd138fcff46e7016f41af21449903bc8-0e93c0924922147c281f79a1639de83aeb0a20ca4ecc9791ac0cdbd9fc1a8363.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 26, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested review from fpletz, vrthra and peti July 26, 2020 21:05
@prusnak
Copy link
Member Author

prusnak commented Jul 26, 2020

@FRidh it seems this causes a lots of rebuilds - should I target this for the staging branch?

@worldofpeace
Copy link
Contributor

go for it

@worldofpeace
Copy link
Contributor

there seems to be another PR https://github.com/NixOS/nixpkgs/pull/87908/files, not sure of it but a patch sounds nicer

@prusnak prusnak mentioned this pull request Jul 27, 2020
Closed
10 tasks
@prusnak prusnak changed the base branch from master to staging July 27, 2020 08:50
@prusnak
Copy link
Member Author

prusnak commented Jul 27, 2020

Rebased to staging

@prusnak
Copy link
Member Author

prusnak commented Jul 27, 2020 •
edited

Let's use the SOURCE_DATE_EPOCH approach instead (#93976)

@prusnak prusnak closed this Jul 27, 2020
@prusnak prusnak deleted the gnupg-r13y branch July 27, 2020 13:11
@prusnak prusnak mentioned this pull request Jul 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@vrthra vrthra Awaiting requested review from vrthra

@peti peti Awaiting requested review from peti

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: python 6.topic: reproducible builds 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @FRidh @worldofpeace