Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobetween: update vendored lxd #93972

Merged
merged 1 commit into from Jul 28, 2020
Merged

gobetween: update vendored lxd #93972

merged 1 commit into from Jul 28, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq mentioned this pull request Jul 27, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from tomberek and kalbasit July 27, 2020 13:27
@zowoq
gobetween: update vendored lxd
e824d42 
This allows us to drop the overrideModAttrs workaround, vendoring has been fixed in the newer lxd version.
@zowoq zowoq marked this pull request as ready for review July 27, 2020 22:55
@zowoq zowoq merged commit 59fd477 into NixOS:master Jul 28, 2020
@zowoq zowoq deleted the gobetween branch July 28, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek Awaiting requested review from tomberek

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zowoq