Use border box or layout overflow rect for layout shift tracking #24762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL addresses the following issues of layout shift tracking:
(originally filed as crbug.com/1090763).
shift report.
It includes the following changes
instead of using location of visual rects as starting points.
overflow rect if the LayoutBox has layout overflow and doesn't clip
overflow. Otherwise use the border box rect.
in containing block logically below the LayoutText, and use that
part of visual representation of the containing block as the visual
representation of the shift.
the initial containing block and viewport.
This has the following benefits:
to the specs;
previous geometry data in LayoutBoxes for paint invalidation.
Bug: 1108622
Change-Id: I7ebb4e250e7ca2a03b4dadea50034e300e55ad84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319538
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793806}