Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] ihatemoney: fix CVE-2020-15120 #93935

Merged
merged 2 commits into from Jul 26, 2020
Merged

[20.03] ihatemoney: fix CVE-2020-15120 #93935

merged 2 commits into from Jul 26, 2020

Conversation

symphorien
Copy link
Member

@symphorien symphorien commented Jul 26, 2020 •
edited

Motivation for this change

CVE-2020-15120

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member Author

@GrahamcOfBorg test python3.pkgs.ihatemoney

@symphorien symphorien changed the title ihatemoney: fix CVE-2020-15120 [20.03] ihatemoney: fix CVE-2020-15120 Jul 26, 2020
@symphorien
Copy link
Member Author

hhm wrong syntax

@GrahamcOfBorg build python3.pkgs.ihatemoney.tests.ihatemoney.ihatemoney-postgresql python3.pkgs.ihatemoney.tests.ihatemoney.ihatemoney-sqlite

@symphorien
Copy link
Member Author

I don't know how of-borg runs tests, but I run them by nix-build nixos/tests/ihatemoney.nix -A ihatemoney-sqlite -A ihatemoney-postgresql and they pass.

@mweinelt
Copy link
Member

@GrahamcOfBorg test ihatemoney

@mweinelt
Copy link
Member

mweinelt commented Jul 26, 2020 •
edited

Why are you bumping the version for 20.03 and applying a patch for master? #93939 Misread.

@symphorien
Copy link
Member Author

because 20.03 is at 4.1 so we can upgrade to 4.1.5 safely, but master is at 4.2 and no later release contains the fix.

@mweinelt mweinelt merged commit b50d558 into NixOS:release-20.03 Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @mweinelt