Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] ghc: add new version 8.8.4 #93940

Merged
merged 2 commits into from Jul 31, 2020
Merged

[20.03] ghc: add new version 8.8.4 #93940

merged 2 commits into from Jul 31, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 26, 2020 •
edited

(cherry picked from commit dd6ce8c)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
[20.03] ghc: add new version 8.8.4
94bba81 
(cherry picked from commit dd6ce8c)
@ggreif
Copy link
Contributor Author

ggreif commented Jul 26, 2020 •
edited

@GrahamcOfBorg build haskell.compiler.ghc884

@ggreif
Copy link
Contributor Author

ggreif commented Jul 26, 2020 •
edited

@peti which one did you mean is needing a backport?

@ofborg ofborg bot requested review from peti and kosmikus July 26, 2020 22:02
@peti
Copy link
Member

peti commented Jul 31, 2020

  • 6d54b2f ghc 8.8.4, 8.10.1: disable profiled builds on aarch64 to avoid 2GB output limit

Back-porting this commit feels like a good idea. I'm not sure how to test whether the change actually works for aarch64, but Hydra might do that verification for us for free, maybe? I suppose @vcunat might be able to advice.

  • 8ffedd8 haskellPackages: bump default compiler to ghc-8.8.4

This commit should NOT be back-ported. Users of a stable release branch probably don't want their default compiler to be updated.

@ggreif
Copy link
Contributor Author

ggreif commented Jul 31, 2020 •
edited

@peti what about switching the default package set from 8.8.3 to 8.8.4? Or should that go as a separate PR?

@ggreif ggreif marked this pull request as ready for review July 31, 2020 19:29
peti
peti approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peti peti merged commit 5d93c17 into NixOS:release-20.03 Jul 31, 2020
@ggreif ggreif deleted the ghc884-backport branch July 31, 2020 19:33
@vcunat
Copy link
Member

vcunat commented Jul 31, 2020

The community aarch64 box would probably be well usable for this. I can run builds there, in case you don't have an account. Actually the borg also runs them there IIRC.

@vcunat
Copy link
Member

vcunat commented Aug 1, 2020

Follows on: #94372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@kosmikus kosmikus Awaiting requested review from kosmikus

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @peti @vcunat