Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg22: 2.2.20 -> 2.2.21 #93976

Merged
merged 1 commit into from Aug 6, 2020
Merged

gnupg22: 2.2.20 -> 2.2.21 #93976

merged 1 commit into from Aug 6, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds successfully for me. Letting ofborg have a go. :)

@wamserma
Copy link
Member

/marvin opt-in

@jtojnar
Copy link
Contributor

jtojnar commented Jul 27, 2020

The release notes look okay to me.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Jul 27, 2020
Fix reproducibility by fixing SOURCE_DATE_EPOCH usage
@srhb
Copy link
Contributor

srhb commented Aug 6, 2020

I'm sorry this fell off my radar. I've reconfirmed that everything looks good with a local build. Thanks!

@srhb srhb merged commit f2be6bd into NixOS:staging Aug 6, 2020
@prusnak prusnak deleted the gnupg branch August 6, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: reproducible builds 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants