Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2199108954ed
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fdfa5b7b05f9
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 27, 2020

  1. applet.memory.prom: s/pass/sample/

    @whitequark
    whitequark committed Jul 27, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    issyl0 Issy Long
    GPG key ID: 8247C390DADC67D4
    Verified
    Learn about vigilant mode
    Copy the full SHA
    fdfa5b7 View commit details
Showing with 10 additions and 10 deletions.
  1. +10 −10 software/glasgow/applet/memory/prom/__init__.py
20 changes: 10 additions & 10 deletions software/glasgow/applet/memory/prom/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -524,14 +524,14 @@ def voltage_range(arg):
p_health_check = p_health_mode.add_parser(
"check", help="quickly probe for unstable words in a memory")
p_health_check.add_argument(
"--passes", metavar="COUNT", type=int, default=5,
"--samples", metavar="COUNT", type=int, default=5,
help="read entire memory COUNT times (default: %(default)s)")

p_health_scan = p_health_mode.add_parser(
"scan", help="exhaustively detect unstable words in a memory")
p_health_scan.add_argument(
"--confirmations", metavar="COUNT", type=int, default=10,
help="read entire memory repeatedly until COUNT consecutive passes "
help="read entire memory repeatedly until COUNT consecutive samples "
"detect no new unstable words (default: %(default)s)")
p_health_scan.add_argument(
"-f", "--file", metavar="FILENAME", type=argparse.FileType("wt"),
@@ -540,7 +540,7 @@ def voltage_range(arg):
p_health_sweep = p_health_mode.add_parser(
"sweep", help="determine undervolt offset that prevents instability")
p_health_sweep.add_argument(
"--passes", metavar="COUNT", type=int, default=5,
"--samples", metavar="COUNT", type=int, default=5,
help="read entire memory COUNT times (default: %(default)s)")
p_health_sweep.add_argument(
"--voltage-step", metavar="STEP", type=float, default=0.05,
@@ -593,8 +593,8 @@ async def interact(self, device, args, prom_iface):
unstable = set()
initial_data = await prom_iface.read(0, depth)

for pass_num in range(args.passes):
self.logger.info("pass %d", pass_num)
for sample_num in range(args.samples):
self.logger.info("sample %d", sample_num)

current_data = await prom_iface.read_shuffled(0, depth)
current_unstable = initial_data.difference(current_data)
@@ -612,11 +612,11 @@ async def interact(self, device, args, prom_iface):
unstable = set()
initial_data = await prom_iface.read(0, depth)

pass_num = 0
sample_num = 0
consecutive = 0
while consecutive < args.confirmations:
self.logger.info("pass %d", pass_num)
pass_num += 1
self.logger.info("sample %d", sample_num)
sample_num += 1
consecutive += 1

current_data = await prom_iface.read_shuffled(0, depth)
@@ -648,8 +648,8 @@ async def interact(self, device, args, prom_iface):
await device.set_voltage(args.port_spec, voltage)

initial_data = await prom_iface.read(0, depth)
for pass_num in range(args.passes):
self.logger.info(" pass %d", pass_num)
for sample_num in range(args.samples):
self.logger.info(" sample %d", sample_num)
current_data = await prom_iface.read_shuffled(0, depth)
unstable = initial_data.difference(current_data)
for index in sorted(unstable):