Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIDIVisualizer: init at 5.1 #93944

Merged
merged 1 commit into from Sep 10, 2020
Merged

MIDIVisualizer: init at 5.1 #93944

merged 1 commit into from Sep 10, 2020

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Jul 27, 2020 •
edited

Motivation for this change

Add MIDIVisualizer application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ericdallo ericdallo self-assigned this Jul 27, 2020
@magnetophon
Copy link
Member

Works for me and looks good, apart from the common pkgconfig mistake.
Done that too many times myself!

@ericdallo
Copy link
Member Author

ericdallo commented Aug 3, 2020 •
edited

Thanks @magnetophon, can you explain what can I change to improve this mistake?

@magnetophon
Copy link
Member

You pinged the wrong person. ;)

Just change pkgconfig to pkg-config.
That's all.

@ericdallo
Copy link
Member Author

Ops haha
thank you, I'll change that!

@Lassulus Lassulus merged commit 173be45 into NixOS:master Sep 10, 2020
@ericdallo ericdallo deleted the add-midi-visualizer branch September 10, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnetophon magnetophon magnetophon approved these changes

Assignees

@ericdallo ericdallo

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @magnetophon @Lassulus