Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cassandra passthru tests #106441

Merged
merged 3 commits into from Dec 14, 2020
Merged

Cassandra passthru tests #106441

merged 3 commits into from Dec 14, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Dec 9, 2020

Motivation for this change
  • Automate cassandra testing via ofborg.
  • Support passthru in NixOS tests (may have other uses)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date - doesn't seem worth writing down. It just works, if you need it. Need is rare, so avoid noise in docs.
  • Fits CONTRIBUTING.md.

@roberth roberth requested review from tfc, andir and Ma27 December 9, 2020 12:18
@roberth roberth mentioned this pull request Dec 9, 2020
Merged
10 tasks
@ofborg ofborg bot added the 6.topic: nixos label Dec 9, 2020
@roberth roberth mentioned this pull request Dec 9, 2020
Merged
10 tasks
drewrisinger
drewrisinger reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on nixos/lib/testing-python.nix changes at all, so this is the rest:

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review & NixOS tests pass: nix-build ./nixpkgs/nixos/tests/cassandra.nix

@roberth
Copy link
Member Author

roberth commented Dec 14, 2020

Thanks @drewrisinger.

The testing-python stuff is rather straightforward. I'd rather have other maintainers review something else, so I'll go ahead and merge this.

@roberth roberth merged commit b37c00a into NixOS:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger left review comments

@tfc tfc Awaiting requested review from tfc

@andir andir Awaiting requested review from andir

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @drewrisinger