Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osm2pgsql: 1.3.0 -> 1.4.0 #106446

Merged
merged 1 commit into from Dec 10, 2020
Merged

osm2pgsql: 1.3.0 -> 1.4.0 #106446

merged 1 commit into from Dec 10, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Dec 9, 2020

Motivation for this change
Note on upstream man page build changes

The man page is now maintained in Markdown and converted with Pandoc, but as the compiled version of the man page is checked into the repo by upstream, we don't need to do that conversion as part of our build and the derivation doesn't have to depend on Pandoc. See README.md of upstream's docs/ subdir.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g
osm2pgsql: 1.3.0 -> 1.4.0
66f90ae 
and set meta.homepage to new website URL
@das-g das-g requested a review from jglukasik December 9, 2020 13:26
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 9, 2020 •
edited

Result of nixpkgs-review pr 106446 1 on darwin

1 package built:
  • osm2pgsql

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106446 run on x86_64-linux 1

1 package built:
  • osm2pgsql

@SuperSandro2000 SuperSandro2000 merged commit 94068bb into NixOS:master Dec 10, 2020
@das-g das-g deleted the osm2pgsql branch December 19, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglukasik jglukasik Awaiting requested review from jglukasik

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @SuperSandro2000