Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amsn: remove application #106432

Merged
merged 1 commit into from Dec 9, 2020
Merged

amsn: remove application #106432

merged 1 commit into from Dec 9, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

The build is broken on hydra since 2020-02-15, the code has not changed since 2012 and is not accepted anymore by the compiler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse merged commit c32ac64 into NixOS:master Dec 9, 2020
@freezeboy freezeboy deleted the remove-amsn branch December 9, 2020 13:04
@SuperSandro2000
Copy link
Member

@aanderse You missed adding the an alias to alias.nix. Please do not self merge things if such vital things are missing!

@aanderse
Copy link
Member

aanderse commented Dec 9, 2020

@SuperSandro2000 gosh I'm sorry... I dropped the ball there. My apologies.
@freezeboy can you please create a PR as mentioned by @SuperSandro2000?

@freezeboy freezeboy mentioned this pull request Dec 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @aanderse