Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: eb458ad1b2d5
Choose a base ref
...
head repository: NixOS/nix
compare: 253571e4ecc9
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Dec 9, 2020

  1. Revert "Re-query for the derivation outputs in the post-build-hook" 

    This reverts commit 1b1e076.

Using `queryPartialDerivationOutputMap` assumes that the derivation
exists locally which isn't the case for remote builders.
    @thufschmitt
    thufschmitt committed Dec 9, 2020
    Copy the full SHA
    6758e65 View commit details
    Browse the repository at this point in the history

  2. Test the post-build-hook with remote builders 

    Regression test for #4245
    @thufschmitt
    thufschmitt committed Dec 9, 2020
    Copy the full SHA
    ee7c94f View commit details
    Browse the repository at this point in the history

  3. Store the final drv outputs in memory when building remotely 

    The `DerivationGoal` has a variable storing the “final” derivation
output paths that is used (amongst other things) to fill the environment
for the post build hook. However this variable wasn't set when the
build-hook is used, causing a crash when both hooks are used together.

Fix this by setting this variable (from the informations in the db) after a run
of the post build hook.
    @thufschmitt
    thufschmitt committed Dec 9, 2020
    Copy the full SHA
    c87267c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #4342 from tweag/fix-remote-build-hook 

    fix remote build hook
    @edolstra
    edolstra committed Dec 9, 2020
    Copy the full SHA
    253571e View commit details
    Browse the repository at this point in the history