Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchfirefoxaddon: support for SRI hashes #106445

Merged
merged 1 commit into from Dec 9, 2020
Merged

fetchfirefoxaddon: support for SRI hashes #106445

merged 1 commit into from Dec 9, 2020

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Dec 9, 2020

Motivation for this change

The most recent Nix tool produces hashes in SRI format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry ehmry requested a review from Qubasa December 9, 2020 13:24
@ofborg ofborg bot added the 6.topic: fetch label Dec 9, 2020
@Qubasa
Copy link
Contributor

Qubasa commented Dec 9, 2020

Do you have an example how to use an SRI hash with fetchfirefoxaddon and how do I create an sri hash? nix-prefetch-url doesn't seem to support it yet.

@ehmry
Copy link
Contributor Author

ehmry commented Dec 9, 2020

nix to-sri --type sha256 <hash>

@ehmry ehmry merged commit e9158ec into NixOS:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubasa Qubasa Awaiting requested review from Qubasa

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmry @Qubasa