Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frab: remove package #106601

Merged
merged 1 commit into from Dec 11, 2020
Merged

frab: remove package #106601

merged 1 commit into from Dec 11, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 10, 2020 •
edited

broken since 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
frab: remove package
6fa3728 
broken since 2018
@ajs124
Copy link
Member

ajs124 commented Dec 11, 2020

There is a PR updating this which went stale #59142

Seems the motivation for it was only to have it not be broken. cc @manveru just in case

@Mic92
Copy link
Member Author

Mic92 commented Dec 11, 2020

From the looks of it, he is also not a user of frab.

@Mic92 Mic92 merged commit d22d922 into NixOS:master Dec 11, 2020
@Mic92 Mic92 deleted the frab branch December 11, 2020 05:27
@Mic92 Mic92 mentioned this pull request Dec 11, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @ajs124