python27Packages.pytestpep8: remove due to pytest v6 incompatibility #106579
Conversation
Remove ``pythonPackages.pytestpep8`` because: * It has been abandoned upstream: no PyPi release since 2014 * It is no longer compatible with pytest v6+: I get an error pointing to https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent when I try to use it with ``pytestCheckHook`` (i.e. pytest v6.0+) * It doesn't have a maintainer
ofborg
bot
added
6.topic: python
8.has: clean-up
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
Converting to a draft b/c I didn't realize how widespread its usage is in the tree. It looks like E.g. |
|
these could be dated references most check phases are most likely not making use of it |
|
@jonringer is it worth removing it then if the check phase isn't making use of it? Just asking before I put in the time going through ~20 packages. |
pytestpep8 was removed in 25c9946. This removes pytestpep8 in the rest of the tree, where it was hardly used.
Build was failing due to line continuation between disabled tests in checkPhase. Fixed by converting to easier syntax of ``pytestCheckHook``.
ofborg
bot
requested review from
ashgillman,
aaronjanse,
primeos,
makefu,
sondr3,
worldofpeace and
winpat
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
labels
|
All of the issues seem to have been addressed. I'm merging this now because the PR unbreaks |
|
I hadn't finished going through & building everything, so I didn't want to unmark it as a draft quite yet. I'll finish this project sometime later today, probably. |
Motivation for this change
Remove
pythonPackages.pytestpep8because:https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent
when I try to use it with
pytestCheckHook(i.e. pytest v6.0+)Removing it will make it clear that it is no longer working, instead of chasing down pytest collection errors when the plugin doesn't work.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)